feat(ironclad): add Ironclad integration with OAuth by waleedlatif1 · Pull Request #3795 · simstudioai/sim

waleedlatif1 · 2026-03-26T22:23:36Z

Summary

Add full Ironclad integration with 12 tools (workflows + records CRUD, approvals, comments)
OAuth 2.0 auth with 10 scopes, centralized via getScopesForService/getCanonicalScopesForProvider
Block with operation dropdown, conditional fields, advanced mode pagination, wandConfig on complex inputs
Docs page with manual description section

Type of Change

New feature

Testing

Tested manually

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

vercel · 2026-03-26T22:23:41Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
docs	Skipped		Mar 26, 2026 11:18pm

cursor · 2026-03-26T22:23:41Z

PR Summary

Medium Risk
Adds a new OAuth provider and a suite of outbound API tools against Ironclad, increasing surface area for auth/config and external API error/contract handling. Changes are mostly additive but touch authentication and tool registries used broadly.

Overview
Adds a new Ironclad integration end-to-end: new IroncladIcon, integration metadata for the landing page, and docs (tools/ironclad.mdx + meta.json) so it appears in docs and UI icon mappings.

Introduces an Ironclad block (blocks/blocks/ironclad.ts) with an operation dropdown and conditional inputs, mapping UI params (e.g., workflowId → ironcladWorkflowId, pagination coercion) to 12 new Ironclad tools.

Extends the platform’s OAuth support to include Ironclad: new env vars (IRONCLAD_CLIENT_ID/SECRET), provider wiring in lib/auth/auth.ts, service/scopes registration in lib/oauth/oauth.ts + types.ts + utils.ts, and registers all new tool implementations in tools/registry.ts.

^{Written by Cursor Bugbot for commit 5d7bad0. Configure here.}

apps/sim/blocks/blocks/ironclad.ts

greptile-apps · 2026-03-26T22:27:59Z

Greptile Summary

This PR adds a full Ironclad contract lifecycle management integration with 12 tools (workflow and record CRUD, approvals, and comments), OAuth 2.0 authentication, a block UI with conditional fields and wand configs, and documentation. The integration follows the established Sim integration patterns well.

Previous review cycles resolved the key defects (unhandled JSON.parse crashes, defensive response parsing for comments/approvals, and the pageSize/perPage response field ambiguity). The remaining concerns are:

Hardcoded na1 Ironclad region: Every tool URL and the OAuth authorization/token/userinfo endpoints are pinned to https://na1.ironcladapp.com. Ironclad is a multi-region SaaS (NA1, EU1, etc.); EU-region customers will be unable to authenticate or make any API calls.
wandConfig.generationType mismatch: The actions subblock prompt explicitly generates a JSON array, but generationType is set to 'json-object', which is semantically inconsistent.

Confidence Score: 5/5

Safe to merge — all P0/P1 issues from prior review rounds are resolved; remaining findings are P2 style/scope concerns.

The three substantive defects from prior review cycles (unhandled JSON.parse crashes, ambiguous response field names, and defensive array parsing) were all fixed. The two remaining comments are P2: a hardcoded region that is a deliberate first-version scope decision, and a generationType annotation mismatch in a wand config. Neither blocks correctness for NA-region users.

apps/sim/tools/ironclad/create_workflow.ts and apps/sim/lib/auth/auth.ts for the hardcoded na1 region; apps/sim/blocks/blocks/ironclad.ts for the generationType mismatch.

Important Files Changed

Filename	Overview
apps/sim/tools/ironclad/create_workflow.ts	Creates workflow via POST; JSON.parse error handling added; URL hardcoded to na1 region.
apps/sim/tools/ironclad/list_workflows.ts	List workflows with pagination; defensive `data.pageSize ?? data.perPage ?? 20` fallback added; looks correct.
apps/sim/tools/ironclad/list_workflow_approvals.ts	Lists approval groups; defensive fallback `data.approvalGroups ?? data ?? []` added per prior review.
apps/sim/tools/ironclad/list_workflow_comments.ts	Lists comments; defensive fallback `data.list ?? data.comments ?? data ?? []` added per prior review.
apps/sim/blocks/blocks/ironclad.ts	Block config with 12 operations, conditional fields, wand configs; `workflowId` rename to avoid framework collision done; `generationType` mismatch on array fields.
apps/sim/lib/auth/auth.ts	Adds Ironclad genericOAuth provider; all endpoints hardcoded to na1 region; getUserInfo handles missing email gracefully.
apps/sim/lib/oauth/oauth.ts	Registers Ironclad in OAUTH_PROVIDERS with 10 scopes; token refresh endpoint hardcoded to na1; supportsRefreshTokenRotation correctly set to true.
apps/sim/tools/ironclad/types.ts	Comprehensive TypeScript interfaces for all 12 tool param/response pairs; well-typed with appropriate nullability.

Sequence Diagram

sequenceDiagram
    participant User
    participant SimBlock as Ironclad Block
    participant Framework as Sim Framework
    participant IroncladAuth as Ironclad OAuth (na1)
    participant IroncladAPI as Ironclad API (na1)

    User->>SimBlock: Select operation + enter params
    SimBlock->>Framework: Resolve oauthCredential → accessToken
    Framework->>IroncladAuth: POST /oauth/token (refresh)
    IroncladAuth-->>Framework: access_token

    alt Create / Update / Cancel Workflow
        Framework->>IroncladAPI: POST/PATCH/POST /public/api/v1/workflows/...
        IroncladAPI-->>Framework: workflow JSON
    else List / Get Workflow
        Framework->>IroncladAPI: GET /public/api/v1/workflows[/{id}]
        IroncladAPI-->>Framework: workflow list / detail JSON
    else Record Operations
        Framework->>IroncladAPI: POST/GET/PATCH /public/api/v1/records[/{id}]
        IroncladAPI-->>Framework: record JSON
    else Comments / Approvals
        Framework->>IroncladAPI: GET/POST /public/api/v1/workflows/{id}/comments|approvals
        IroncladAPI-->>Framework: comments / approvals JSON
    end

    Framework-->>SimBlock: Transformed output
    SimBlock-->>User: Result

_{Reviews (6): Last reviewed commit: "lint" | Re-trigger Greptile}

apps/sim/tools/ironclad/list_workflow_comments.ts

apps/sim/tools/ironclad/list_workflows.ts

…defensive response parsing

waleedlatif1 · 2026-03-26T22:36:09Z

@greptile

waleedlatif1 · 2026-03-26T22:36:13Z

@cursor review

apps/sim/lib/auth/auth.ts

apps/sim/tools/ironclad/update_workflow_metadata.ts

apps/sim/tools/ironclad/create_workflow.ts

apps/sim/tools/ironclad/create_record.ts

…onse

waleedlatif1 · 2026-03-26T22:51:30Z

@greptile

waleedlatif1 · 2026-03-26T22:51:34Z

@cursor review

apps/sim/tools/ironclad/list_workflows.ts

apps/sim/tools/ironclad/update_record.ts

waleedlatif1 · 2026-03-26T23:03:18Z

@greptile

waleedlatif1 · 2026-03-26T23:03:22Z

@cursor review

apps/sim/blocks/blocks/ironclad.ts

waleedlatif1 · 2026-03-26T23:18:16Z

@greptile

waleedlatif1 · 2026-03-26T23:18:20Z

@cursor review

cursor

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

feat(ironclad): add Ironclad integration with OAuth

b298b4a

vercel bot deployed to Preview March 26, 2026 22:26 View deployment

cursor bot reviewed Mar 26, 2026

View reviewed changes

apps/sim/blocks/blocks/ironclad.ts Show resolved Hide resolved

greptile-apps bot reviewed Mar 26, 2026

View reviewed changes

apps/sim/tools/ironclad/list_workflow_comments.ts Show resolved Hide resolved

apps/sim/tools/ironclad/list_workflows.ts Show resolved Hide resolved

fix(ironclad): address PR review comments - add required constraint, …

eca3450

…defensive response parsing

vercel bot temporarily deployed to Preview March 26, 2026 22:33 Inactive

cursor bot reviewed Mar 26, 2026

View reviewed changes

apps/sim/lib/auth/auth.ts Show resolved Hide resolved

apps/sim/tools/ironclad/update_workflow_metadata.ts Outdated Show resolved Hide resolved

greptile-apps bot reviewed Mar 26, 2026

View reviewed changes

apps/sim/tools/ironclad/create_workflow.ts Outdated Show resolved Hide resolved

apps/sim/tools/ironclad/create_record.ts Show resolved Hide resolved

fix(ironclad): add ironclad to OAuthProvider and OAuthService types

13e8ea3

vercel bot temporarily deployed to Preview March 26, 2026 22:41 Inactive

fix(ironclad): add JSON.parse error handling and .catch on error resp…

8e68483

…onse

vercel bot temporarily deployed to Preview March 26, 2026 22:42 Inactive

fix(ironclad): add supportsRefreshTokenRotation to token refresh config

800cfb0

vercel bot temporarily deployed to Preview March 26, 2026 22:46 Inactive

cursor bot reviewed Mar 26, 2026

View reviewed changes

apps/sim/tools/ironclad/list_workflows.ts Show resolved Hide resolved

apps/sim/tools/ironclad/update_record.ts Show resolved Hide resolved

cursor bot reviewed Mar 26, 2026

View reviewed changes

apps/sim/blocks/blocks/ironclad.ts Show resolved Hide resolved

fix(ironclad): use !== undefined for page=0 guard in block config

e7764b8

vercel bot temporarily deployed to Preview March 26, 2026 23:07 Inactive

fix(ironclad): rename workflowId param to avoid framework collision

fd1182f

vercel bot temporarily deployed to Preview March 26, 2026 23:12 Inactive

lint

5d7bad0

vercel bot temporarily deployed to Preview March 26, 2026 23:18 Inactive

cursor bot reviewed Mar 26, 2026

View reviewed changes

waleedlatif1 deleted the branch staging April 3, 2026 23:01

waleedlatif1 closed this Apr 3, 2026

waleedlatif1 reopened this Apr 3, 2026

Conversation

waleedlatif1 commented Mar 26, 2026

Summary

Type of Change

Testing

Checklist

Uh oh!

vercel bot commented Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cursor bot commented Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

Uh oh!

Uh oh!

greptile-apps bot commented Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Sequence Diagram

Uh oh!

Uh oh!

Uh oh!

waleedlatif1 commented Mar 26, 2026

Uh oh!

waleedlatif1 commented Mar 26, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

waleedlatif1 commented Mar 26, 2026

Uh oh!

waleedlatif1 commented Mar 26, 2026

Uh oh!

Uh oh!

Uh oh!

waleedlatif1 commented Mar 26, 2026

Uh oh!

waleedlatif1 commented Mar 26, 2026

Uh oh!

Uh oh!

waleedlatif1 commented Mar 26, 2026

Uh oh!

waleedlatif1 commented Mar 26, 2026

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

vercel bot commented Mar 26, 2026 •

edited

Loading

cursor bot commented Mar 26, 2026 •

edited

Loading

greptile-apps bot commented Mar 26, 2026 •

edited

Loading